Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use spot price in multi payment instead of pool trade #290

Merged
merged 13 commits into from
Dec 18, 2021

Conversation

enthusiastmartin
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 16, 2021

Crate versions that have not been updated:

  • basilisk-runtime: v27.0.0
  • testing-basilisk-runtime: v27.0.0

Crate versions that have been updated:

  • pallet-transaction-multi-payment: v6.2.1 -> v6.3.0
  • pallet-multi-payment-benchmarking: v5.2.1 -> v5.3.0

Runtime versions don't match.

Runtime version has not been increased.

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #290 (31f81be) into master (6c03e13) will increase coverage by 0.00%.
The diff coverage is 85.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #290   +/-   ##
=======================================
  Coverage   81.90%   81.91%           
=======================================
  Files          21       21           
  Lines        2211     2206    -5     
=======================================
- Hits         1811     1807    -4     
+ Misses        400      399    -1     
Impacted Files Coverage Δ
pallets/transaction-multi-payment/src/lib.rs 74.16% <83.33%> (-0.24%) ⬇️
.../transaction-multi-payment/benchmarking/src/lib.rs 96.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c03e13...31f81be. Read the comment docs.

pallets/transaction-multi-payment/src/lib.rs Outdated Show resolved Hide resolved
pallets/transaction-multi-payment/src/lib.rs Outdated Show resolved Hide resolved
@mrq1911
Copy link
Member

mrq1911 commented Dec 17, 2021

pallet should be rebenched and benchamrks pallet version bumped

@enthusiastmartin enthusiastmartin merged commit 3392230 into master Dec 18, 2021
@enthusiastmartin enthusiastmartin deleted the feat/multi-payment-spot-price branch December 18, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use spot price instead of pool trade in multi payment pallet
2 participants