Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add s3 dirctory option #457

Merged
merged 1 commit into from
Aug 7, 2017
Merged

add s3 dirctory option #457

merged 1 commit into from
Aug 7, 2017

Conversation

sadayuki-matsuno
Copy link
Collaborator

What did you implement:

I want to put to s3 with a specific directory name.

How did you implement it:

Add S3 directory option -aws-s3-dir=/path/to/results's/parent

How can we verify it:

$ vuls report -to-s3 -format-json -aws-region=ap-northeast-1 -aws-s3-bucket=vuls -aws-s3-dir=something/something -aws-profile=vuls

Todos:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@kotakanbe kotakanbe force-pushed the support_oval branch 6 times, most recently from 0acc65e to 23f1d58 Compare August 7, 2017 01:19
@kotakanbe kotakanbe merged commit 0a255f2 into future-architect:support_oval Aug 7, 2017
kotakanbe pushed a commit that referenced this pull request Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants