Ensuring that ZarrToZarr metadata is inlined #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The do_inline function in utils.py will now inline when a user has generated references from ZarrToZarr which is now consistent with the other scanners Resolves fsspec#402
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for ZarrToZarr Metadata Inlining
Previously (#402), using
ZarrToZarrbeforeMultiZarrtoZarrwould cause an issue since the metadata files weren't inlined in the references as they are in the other scanners. This forces the metadata files to be inlined so that it the assumptions withinMultiZarrtoZarrhold.The do_inline function in utils.py will now inline when a user has generated references from ZarrToZarr which is now consistent with the other scanners
Resolves #402