Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(upgrade): v1.9.0 to v1.10.0 #2104

Merged
merged 8 commits into from
Aug 1, 2024
Merged

chore(upgrade): v1.9.0 to v1.10.0 #2104

merged 8 commits into from
Aug 1, 2024

Conversation

enddynayn
Copy link
Collaborator

@enddynayn enddynayn commented Jul 30, 2024 •
edited
Loading

  • Upgrade Polkadot-sdk 1.9.0 to 1.10.0
  • Update weights to reflect the new version.

Notable Changes:

For more details, please refer to:

Release Notes

#1928

@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928 branch 4 times, most recently from 474c0f9 to 9b6fa5c Compare July 30, 2024 19:23
@enddynayn enddynayn changed the title - Upgrade Polkadot-sdk to v.1.10.0. chore(upgrade): v1.9.0 to v1.10.0 Jul 30, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jul 30, 2024
@enddynayn enddynayn marked this pull request as ready for review July 30, 2024 22:59
@enddynayn enddynayn requested a review from wilwade as a code owner July 30, 2024 22:59
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928 branch from 2a7dccd to 0e84494 Compare July 30, 2024 23:00
@github-actions github-actions bot removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jul 30, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928 branch from 0e84494 to f95ebf1 Compare July 30, 2024 23:01
@enddynayn enddynayn marked this pull request as draft July 30, 2024 23:02
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jul 30, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928 branch 3 times, most recently from 80a8804 to 672b981 Compare July 31, 2024 15:13
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jul 31, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928 branch 8 times, most recently from dbceeab to e19190b Compare August 1, 2024 14:00
@enddynayn
chore(upgrade): v1.9.0 to v1.10.0
ebe7363 
- Upgrade Polkadot-sdk 1.9.0 to 1.10.0
- Update weights to reflect the new version.

Notable Changes:
- [Remove experimental flag](/~https://github.com/paritytech/polkadot-sdk/pull/3654/files)
- [Remove pallet::getter macro](paritytech/polkadot-sdk#3350)
- [Refactor APIs](/~https://github.com/paritytech/polkadot-sdk/pull/3817/files#diff-b02373af4015a8ebdf3a3f5be9ea0ce555b6e45331872e0465fd2f488177d383)
- [Refactor Unified Host Functions](paritytech/polkadot-sdk#3854)
- [StorageWeightReclaim SignedExtension](/~https://github.com/paritytech/polkadot-sdk/pull/3002/files)

For more details, please refer to:

[Release Notes](/~https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.10.0)
@enddynayn
use unified host functions
a6cc125
@enddynayn
Pov reclaim
06462ac
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928 branch from 21a1260 to 06462ac Compare August 1, 2024 15:00
@enddynayn enddynayn marked this pull request as ready for review August 1, 2024 15:01
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 1, 2024
@enddynayn enddynayn requested a review from demisx as a code owner August 1, 2024 16:00
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Aug 1, 2024
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Aug 1, 2024
saraswatpuneet
saraswatpuneet approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not notice any major changes aside from big refactor which look 👍🏽

@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Aug 1, 2024
aramikm
aramikm approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the code and looked good. There are some questions about weight changes. In general they are decreased but they are increased for base block and base extrinsic.

pallets/capacity/src/weights.rs
// Minimum execution time: 39_381_000 picoseconds.
Weight::from_parts(40_678_000, 6249)
// Minimum execution time: 35_236_000 picoseconds.
Weight::from_parts(36_395_000, 6249)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Do we know why this is reduced?

runtime/common/src/weights/block_weights.rs
pub const BlockExecutionWeight: Weight =
Weight::from_parts(WEIGHT_REF_TIME_PER_NANOS.saturating_mul(245_079), 0);
Weight::from_parts(WEIGHT_REF_TIME_PER_NANOS.saturating_mul(355_340), 0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I wonder why is this increased 100k

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. We added a new Signed Extension.

@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928 branch from 62b42de to 3aa9a19 Compare August 1, 2024 20:07
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Aug 1, 2024
claireolmstead
claireolmstead approved these changes Aug 1, 2024
View reviewed changes
Copy link
Collaborator

@claireolmstead claireolmstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really any logic changes or anything. As long as it works, LGTM!

@enddynayn enddynayn merged commit 1e83130 into main Aug 1, 2024
27 checks passed
@enddynayn enddynayn deleted the chore/upgrade-polkadot-v1.9.0-to-v1.10.0-issue-1928 branch August 1, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

@claireolmstead claireolmstead claireolmstead approved these changes

@aramikm aramikm aramikm approved these changes

@wilwade wilwade Awaiting requested review from wilwade wilwade is a code owner

@JoeCap08055 JoeCap08055 Awaiting requested review from JoeCap08055

@demisx demisx Awaiting requested review from demisx demisx is a code owner

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enddynayn @aramikm @claireolmstead @saraswatpuneet