Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial constant-time implementation of Base64 for generic & AVX2 #1

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Initial constant-time implementation of Base64 for generic & AVX2 #1

merged 1 commit into from
Apr 23, 2020

Conversation

jethrogb
Copy link
Member

@jethrogb jethrogb commented Jul 22, 2019 •
edited
Loading

TODO:

  • Update README
  • Update Cargo.toml
  • Update documentation in src/lib.rs
  • Setup CI

jack-fortanix
jack-fortanix approved these changes Jul 31, 2019
View reviewed changes
src/decode/avx2.rs Outdated Show resolved Hide resolved
src/avx2.rs Show resolved Hide resolved
src/avx2.rs Show resolved Hide resolved
src/decode/avx2.rs Show resolved Hide resolved
src/decode/avx2.rs Outdated Show resolved Hide resolved
src/decode/avx2.rs Outdated Show resolved Hide resolved
src/decode/avx2.rs Outdated Show resolved Hide resolved
src/decode/lut_align64.rs Outdated Show resolved Hide resolved
src/encode/lut_align64.rs Show resolved Hide resolved
@jethrogb jethrogb force-pushed the jb/initial branch 2 times, most recently from 86cbb02 to 825280b Compare April 22, 2020 11:39
jethrogb
jethrogb commented Apr 22, 2020
View reviewed changes
src/lib.rs Show resolved Hide resolved
jack-fortanix
jack-fortanix approved these changes Apr 22, 2020
View reviewed changes
Copy link

@jack-fortanix jack-fortanix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a pass over everything, looks good to me

src/lib.rs Show resolved Hide resolved
@jethrogb
Copy link
Member Author

bors r=jack-fortanix

@bors
Copy link
Contributor

bors bot commented Apr 23, 2020

Build succeeded:

  • continuous-integration/travis-ci/push

@bors bors bot merged commit ba5e463 into master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-fortanix jack-fortanix jack-fortanix approved these changes

@jseyfried jseyfried Awaiting requested review from jseyfried

Assignees

@jseyfried jseyfried

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jethrogb @jack-fortanix @jseyfried