-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a benchmark for compilation times #1959
Conversation
Try this Pull Request!Open Julia and type: julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="/~https://github.com/rikhuijzer/Pluto.jl", rev="rh/precompile-macro")
julia> using Pluto |
This comment was marked as outdated.
This comment was marked as outdated.
I've added
Don't take these times too seriously. This run was on a particularly slow runner. Look at allocations. I guess this provides a good idea of the tradeoff between running time and adding these directives. In this case, the 3 extra directives save 0.4 seconds in total or so on my pc. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I made JuliaPackaging/RelocatableFolders.jl#15 about this. Did you switch git branches? |
This comment was marked as outdated.
This comment was marked as outdated.
This is how the output looks now:
The |
@fonsp Can you review this? |
I took the sessionactions precompile statements out, let's do that in a new PR (also so that we can use these timing to see the difference!!) |
Thanks!! Looks great! Seeing allocations seems very useful in CI |
precompile statements in #1977 |
Want meten is weten (because measuring is knowning). I've tried to do something fancy like rikhuijzer/PrecompileMacro.jl#1, but that will take some (a lot of) time to make. So, as a first step, this PR just adds a separate benchmark for compilation time. I think that I've missed a lot of entry points, but I hope that once we are able to pin down what spots are compiled exactly, then we can start making progress on improving the performance.