add flux --root option
#6557
Merged
add flux --root option
#6557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: A few lines in `src/cmd/flux.c` do not conform to modern project style. Long parameter lists are not split into one parameter per line. Fix the formatting.
Problem: There's an unused `uri` parameter passed to flux_open_internal() in src/cmd/flux.c. This could confuse callers that the function accepts an alternate uri when it always passes NULL as the URI parameter to flux_open(3). Remove the unused parameter to avoid the confusion.
Problem: push_parent_environment() in `src/cmd/flux.c` calls `flux_open_internal()` after pushing the parent environment, but this is a no-op because the environment has not yet been applied. Drop the useless `flux_open_internal()` call.
Problem: While the `flux(1)` command supports operating on parent URIs by specifying one or more `--parent` options on the command line, there is no way to easily specify the top-level or root parent. Add a `--root` option which acts if `instance-level` number of `--parent` options were supplied to the command.
Problem: The `--root` option to `flux(1)` is undocumented. Document it.
Problem: There are no tests of the `flux --root` option. Add some tests to t3100-flux-in-flux.t.
chu11
approved these changes
Jan 17, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
flux --parent [--parent] COMMAND ARGS...is supported to connect to parent (grandparent, etc.), it seems neglectful that a method to connect to the top-level or root instance is not also provided. Instead, users have to supply the--parentoption at leastinstance-leveltimes: an admittedly awkward interface.This PR adds a
--rootoption toflux(1)that behaves exactly as if--parenthad been specifiedinstance-leveltimes. Ifinstance-levelis0, this option has no effect (same as--parent).