Add Traditional Chinese localization #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gasol
force-pushed
the
traditional-chinese-text-delegate
branch
from
f86b4d6 to
9ad3d36
Compare
AlexV525
requested changes
Dec 11, 2024
Gasol
force-pushed
the
traditional-chinese-text-delegate
branch
from
9ad3d36 to
96310ae
Compare
Gasol
force-pushed
the
traditional-chinese-text-delegate
branch
from
96310ae to
e6e1a2f
Compare
AlexV525
reviewed
Dec 12, 2024
|
I saw the video with the VoiceOver but it doesn't show the actual grid. Please attach a video that walks through actual assets. If the video needs to be no public sharing, send it to fluttercandies@googlegroups.com. EDIT: There might be attachment size limitations with Google Groups. Let us know if you need to send the email and was sent. |
This change adds Traditional Chinese localization and return it when the locale is zh-Hant. We have to use the languageCode and scriptCode to differentiate between Simplified and Traditional Chinese. Summary of changes: - Implement TraditionalChineseAssetPickerTextDelegate - Add TraditionalChineseAssetPickerTextDelegate to the list of delegates. - Sort the list of delegates alphabetically. - Remove all toLowerCase() calls to make sure we can return the correct delegate.
Gasol
force-pushed
the
traditional-chinese-text-delegate
branch
from
e6e1a2f to
227558a
Compare
Here you go, The link will expire on Jan 11, 2015. |
AlexV525
approved these changes
Dec 12, 2024
|
@all-contributors Add @Gasol for localizations. |
|
I couldn't determine any contributions to add, did you specify any contributions? |
|
@all-contributors Add @Gasol for translation |
|
I've put up a pull request to add @Gasol! 🎉 |
AlexV525
pushed a commit
that referenced
this pull request
Dec 12, 2024
Adds @Gasol as a contributor for translation. This was requested by AlexV525 [in this comment](#667 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
tourdt
pushed a commit
to tourdt/flutter_wechat_assets_picker
that referenced
this pull request
Dec 16, 2024
…at_assets_picker * 'main' of /~https://github.com/fluttercandies/flutter_wechat_assets_picker: docs: add Gasol as a contributor for translation (fluttercandies#669) Add Traditional Chinese localization (fluttercandies#667) 🚀 Support matching script and country code of locales with the text delegate (fluttercandies#668) 💡 Refreshes tests copyright 🔖 9.4.1 🔖 9.4.1 Fix selecting when reached the max asset limit in the preview (fluttercandies#648) 🚸 Improves the default sort conditions (fluttercandies#662) ⬆️ Allows `extended_image: ^9.0.0` (fluttercandies#659) 🐛 Allows assets changing when no path previously (fluttercandies#656) 👷 Try to run on minimum SDK requirement (fluttercandies#643) 🔖 9.3.2 🚀 Adapt the image provider file type getter (fluttercandies#638) 🔖 9.3.1 🐛 Fix UI layouts (fluttercandies#634)
tourdt
pushed a commit
to tourdt/flutter_wechat_assets_picker
that referenced
this pull request
Dec 16, 2024
* main: docs: add Gasol as a contributor for translation (fluttercandies#669) Add Traditional Chinese localization (fluttercandies#667) 🚀 Support matching script and country code of locales with the text delegate (fluttercandies#668) 💡 Refreshes tests copyright 🔖 9.4.1 🔖 9.4.1 Fix selecting when reached the max asset limit in the preview (fluttercandies#648) 🚸 Improves the default sort conditions (fluttercandies#662) ⬆️ Allows `extended_image: ^9.0.0` (fluttercandies#659) 🐛 Allows assets changing when no path previously (fluttercandies#656) 👷 Try to run on minimum SDK requirement (fluttercandies#643) 🔖 9.3.2 🚀 Adapt the image provider file type getter (fluttercandies#638) 🔖 9.3.1 🐛 Fix UI layouts (fluttercandies#634) # Conflicts: # lib/src/delegates/asset_picker_builder_delegate.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds Traditional Chinese localization and return it when the
locale is zh-Hant. We have to use the languageCode and scriptCode to
differentiate between Simplified and Traditional Chinese.
Summary of changes:
delegate.
RPReplay_Final1733835936.mp4