Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Test that flutter run doesn't introduce new debug spew #114554

Closed
wants to merge 6 commits into from
Closed

[WIP] Test that flutter run doesn't introduce new debug spew #114554

wants to merge 6 commits into from

Conversation

loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Nov 2, 2022 •
edited
Loading

⚠️ Blocked on previous PRs:

  1. Refactor macOS test: [macOS] Refactor the flutter run macOS console output test #114645
  2. Refactor Android test: [Android] Refactor the flutter run Android console output test #115023
  3. Add Windows test: [Windows] Add a flutter run console output test #116626

See: #111577

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Nov 2, 2022
loic-sharma
loic-sharma commented Nov 3, 2022
View reviewed changes
dev/devicelab/lib/tasks/run_tests.dart
/// Whether to run the app in release mode.
final bool release;
/// Extra options to pass to `flutter run`.
final List<String> extraOptions;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this, it's unused

@loic-sharma
Copy link
Member Author

Replaced by #116798

@loic-sharma loic-sharma closed this Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey Awaiting requested review from matanlurey matanlurey will be requested when the pull request is marked ready for review matanlurey is a code owner

Assignees
No one assigned
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@loic-sharma