Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement working search bar in reverse dependencies #389

Conversation

dylan-thinnes
Copy link
Contributor

@dylan-thinnes dylan-thinnes commented Jun 10, 2023

Proposed changes

Reverse dependency lists (a.k.a dependents) can get huge, e.g. for the lens library, which makes pagination impractical. This implements a search bar in the reverse dependencies page.

TODOS:

  • There is definitely still some work to be done on styling the search bar to be a nicer size, but this is something I'd rather get feedback on.
  • There's also some work to be done on cleaning up duplication in the SQL code, I'll make them once we're certain that the semantic behaviour as implemented now is what we want.

Contributor checklist

Reverse dependency lists (a.k.a dependents) can get huge, e.g. for lens
library. This implements a search bar in the reverse dependencies page.

Probably still some work to be done on styling.
@tchoutri
Copy link
Contributor

here it was it looks like right now:

Screenshot 2023-06-11 at 13-54-46 @haskell_base

@tchoutri
Copy link
Contributor

@dylan-thinnes Hi! Would you like me to take the relay on this PR if you're having a hard time finishing it? I know it's hard to find the motivation and excitement after the hackathon has ended. :)

@dylan-thinnes
Copy link
Contributor Author

dylan-thinnes commented Jun 24, 2023

Haha heya! No worries, I just was taking some time off to recover. I'll stage some of the work in the next few days, which I think gets us almost all of the way there, and you can tell me if it feels like things are heading in the direction you think's good.

@tchoutri
Copy link
Contributor

@dylan-thinnes if that's not asking too much, I'd like to know how you're doing with the PR and if you'd like to pair with me sometime, or you can just push your code and I'll take it from here. :)

@tchoutri tchoutri mentioned this pull request Aug 7, 2023
3 tasks
@tchoutri
Copy link
Contributor

@dylan-thinnes If you don't mind I will port your PR and adapt it to the latest changes that landed in development. :) Thanks a bunch for all the work!

@tchoutri
Copy link
Contributor

Closed by #476

@tchoutri tchoutri closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants