Skip to content

Commit

Permalink
Fixes #65 (#73)
Browse files Browse the repository at this point in the history
Remove ktor-http Dependency from ksoup-core by Implementing String.resolveOrNull in Pure Kotlin
  • Loading branch information
itboy87 authored Sep 11, 2024
1 parent 18dffa0 commit 6cf3b52
Show file tree
Hide file tree
Showing 16 changed files with 194 additions and 503 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import com.fleeksoft.ksoup.io.FileSource
import com.fleeksoft.ksoup.io.SourceReader

interface KsoupEngine {
fun urlResolveOrNull(base: String, relUrl: String): String?

fun openSourceReader(content: String, charset: Charset? = null): SourceReader

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,8 @@ package com.fleeksoft.ksoup.engine

import com.fleeksoft.ksoup.io.*
import korlibs.io.lang.Charsets
import korlibs.io.net.URL

object KsoupEngineImpl : KsoupEngine {
override fun urlResolveOrNull(base: String, relUrl: String): String? {
return URL.resolveOrNull(base = base, access = relUrl)
}

override fun openSourceReader(content: String, charset: Charset?): SourceReader {
return SourceReader.from(charset?.toByteArray(content) ?: content.encodeToByteArray())
Expand Down
3 changes: 1 addition & 2 deletions ksoup-engine-kotlinx/module.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,4 @@ aliases:
dependencies:
- ../ksoup-engine-common
- $libs.kotlinx.io: exported
- $libs.ktor.io
- $libs.ktor.http
- $libs.ktor.io
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ import io.ktor.utils.io.charsets.*

object KsoupEngineImpl : KsoupEngine {

override fun urlResolveOrNull(base: String, relUrl: String): String? {
return URLUtil.urlResolveOrNull(base = base, relUrl = relUrl)
}

override fun openSourceReader(content: String, charset: Charset?): SourceReader {
return SourceReader.from(charset?.toByteArray(content) ?: content.encodeToByteArray())
}
Expand Down
153 changes: 0 additions & 153 deletions ksoup-engine-kotlinx/src/com/fleeksoft/ksoup/engine/URLUtil.kt

This file was deleted.

3 changes: 1 addition & 2 deletions ksoup-engine-ktor2/module.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,4 @@ aliases:
dependencies:
- ../ksoup-engine-common
- $libs.kotlinx.io: exported
- $libs.ktor2.io
- $libs.ktor2.http
- $libs.ktor2.io
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ import io.ktor.utils.io.charsets.*

object KsoupEngineImpl : KsoupEngine {

override fun urlResolveOrNull(base: String, relUrl: String): String? {
return URLUtil.urlResolveOrNull(base = base, relUrl = relUrl)
}

override fun openSourceReader(content: String, charset: Charset?): SourceReader {
return SourceReader.from(charset?.toByteArray(content) ?: content.encodeToByteArray())
}
Expand Down
153 changes: 0 additions & 153 deletions ksoup-engine-ktor2/src/com/fleeksoft/ksoup/engine/URLUtil.kt

This file was deleted.

1 change: 0 additions & 1 deletion ksoup-engine-okio/module.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ dependencies:
- ../ksoup-engine-common
- $libs.okio: exported
- $libs.ktor2.io
- $libs.ktor2.http

dependencies@js:
- $libs.okio.nodefilesystem
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ import io.ktor.utils.io.charsets.*

object KsoupEngineImpl : KsoupEngine {

override fun urlResolveOrNull(base: String, relUrl: String): String? {
return URLUtil.urlResolveOrNull(base = base, relUrl = relUrl)
}

override fun openSourceReader(content: String, charset: Charset?): SourceReader {
return SourceReader.from(charset?.toByteArray(content) ?: content.encodeToByteArray())
}
Expand Down
Loading

0 comments on commit 6cf3b52

Please sign in to comment.