Gzip fix #382
Closed
Gzip fix #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #382 +/- ##
==========================================
+ Coverage 66.02% 66.59% +0.56%
==========================================
Files 7 7
Lines 889 895 +6
==========================================
+ Hits 587 596 +9
+ Misses 265 264 -1
+ Partials 37 35 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jtraglia
approved these changes
Oct 21, 2022
|
Oh interesting, I must have not been testing this properly then. It's worth double checking then if this has any performance improvements (have employed gzip to a few other internal services recently and have always seen improvement fwiw). Did you see any difference in your tests on sepolia? I can also do some testing this weekend |
|
the test from the old PR works now, before it wouldn't be active because accept-encoding wasn't actually sent (no payload) |
|
For some background: The rc-1 version was tested on Sepolia with just the original PR #365 in it, and there were these errors: Only after deploying this PR did the decoding work. Checking what's up with the test in the original PR... |
|
It seems that So actually, it looks like there already was gzip support from the beginning! |
3 tasks
|
gzip support was already part of mev-boost since the beginning, because http.Request automatically adds this functionality. See also #383 |
|
wow TIL! Sorry for the waste of time 🤦 I think the performance improvements we saw were then simply from enabling gzip in our reverse proxy |
|
No problem at all! Thanks for continuing. And glad to learn about go http requests automatically accepting gzip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fix bugs in requesting gzip encoded response (#365. cc/ @dmarzzz)
Docker image: v1.4.0-rc3
Tested successfully in Sepolia by Kiln.fi
✅ I have run these commands
make lintmake test-racego mod tidy