Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary log.WithField calls #350

Merged
merged 2 commits into from
Sep 24, 2022
Merged

Remove unnecessary log.WithField calls #350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dd184c
Remove unnecessary log.withField calls
jtraglia Sep 23, 2022
7ab2c40
Merge branch 'main' into remove-unnecessary-log-with-fields
metachris Sep 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/test-cli/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
"github.com/flashbots/mev-boost/server"
)

var log = logrus.WithField("service", "cmd/test-cli")
var log = logrus.NewEntry(logrus.New())

func doGenerateValidator(filePath string, gasLimit uint64, feeRecipient string) {
v := newRandomValidator(gasLimit, feeRecipient)
Expand Down
2 changes: 1 addition & 1 deletion server/mock_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
)

// testLog is used to log information in the test methods
var testLog = logrus.WithField("testing", true)
var testLog = logrus.NewEntry(logrus.New())

// _HexToBytes converts a hexadecimal string to a byte array
func _HexToBytes(hex string) []byte {
Expand Down
2 changes: 1 addition & 1 deletion server/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ func NewBoostService(opts BoostServiceOpts) (*BoostService, error) {
listenAddr: opts.ListenAddr,
relays: opts.Relays,
relayMonitors: opts.RelayMonitors,
log: opts.Log.WithField("module", "service"),
log: opts.Log,
relayCheck: opts.RelayCheck,
bids: make(map[bidRespKey]bidResp),

Expand Down