Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add german translation #467

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

DaVukovic
Copy link
Contributor

As I received help here I thought it might be a good idea to give something back.

Not a experienced developer at all, so please bear with me if you might find any issues. I'm absolutely not sure if the edits I've done for the CONTRIBUTING.md file are correct.

Please feel free to give any kind of feedback and I happily amend some edits

I tested this with Ubuntu 16.04 and 18.04 and AFAICT, I can't find anything missing.

@DaVukovic
Copy link
Contributor Author

I'm not 100% sure, but I would say, the error is not related to my PR. Maybe @lupoDharkael could take a look.

@holazt
Copy link
Member

holazt commented Feb 14, 2019

@DaVukovic I‘m sure that's a problem of travisci.

@DaVukovic
Copy link
Contributor Author

Thanks for answering. Thought so.

@AlfredoRamos
Copy link
Contributor

It seems to be a timeout. You can close and re-open the this pull request to trigger the tests again.

@lupoDharkael
Copy link
Collaborator

I'll restart the build

@DaVukovic DaVukovic force-pushed the german_translation branch 2 times, most recently from 6d278c0 to 82b904f Compare March 13, 2019 12:24
@DaVukovic
Copy link
Contributor Author

rebased and merge conflicts solved

@lupoDharkael
Copy link
Collaborator

The CI seems to be failing due to RPM errors. @ZetaoYang any idea?

@holazt
Copy link
Member

holazt commented Mar 14, 2019

@lupoDharkael @DaVukovic

Travisci error:

lrelease error: Cannot open translations/Internationalization_de.DE.ts: No such file or directory

Appveyor error:

lrelease error: Cannot open translations/Internationalization_de.DE.ts: The system cannot find the file specified.

Name of Internationalization_de.DE.ts is not standard. (P.S. Why _de.DE. is? Please try _de_DE again.)

@DaVukovic
Copy link
Contributor Author

Yeah, seen that already. Just haven't found the time. Most likely an error on my side.

I'll let you know if I can solve it

Thanks for the heads up ;)

@DaVukovic DaVukovic force-pushed the german_translation branch from 82b904f to ffd02e1 Compare March 14, 2019 08:54
@DaVukovic
Copy link
Contributor Author

Let's hope it was a typo only ;)

@holazt
Copy link
Member

holazt commented Mar 14, 2019

@DaVukovic @lupoDharkael It could be merged now.

@lupoDharkael
Copy link
Collaborator

Thanks!

@lupoDharkael lupoDharkael merged commit abe356a into flameshot-org:master Mar 20, 2019
@DaVukovic DaVukovic deleted the german_translation branch March 26, 2019 20:57
@holazt holazt added the Translation Translation-related issue/PR label Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Translation Translation-related issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants