Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias *gemmt_ as *gemmtr_ to fix lapack 3.12.1 compatibility. (Closes: #848) #849

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Alias *gemmt_ as *gemmtr_ to fix lapack 3.12.1 compatibility. (Closes: #848) #849

merged 3 commits into from
Feb 5, 2025

Conversation

cdluminate
Copy link
Contributor

The patch is sufficient to address the issue that liblapack.so says it cannot find symbol sgemmtr_. The cblas part is not yet done. I'll look into that and update this PR. Or if it works for you, I can do a separate PR for the cblas alias.

@cdluminate cdluminate mentioned this pull request Jan 28, 2025
Closed
@cdluminate
Copy link
Contributor Author

@devinamatthews I pushed the changes for cblas_?gemmtr as well. The PR should be able to fully address #848.

@devinamatthews devinamatthews merged commit a6f2ce9 into flame:master Feb 5, 2025
1 check passed
devinamatthews pushed a commit that referenced this pull request Feb 5, 2025
@cdluminate @devinamatthews
Alias *gemmt_ as *gemmtr_ to fix lapack 3.12.1 compatibility. (#849)
84e2ed7 
Details:
- Alias `?gemmt_` as `?gemmtr_` to fix lapack 3.12.1 compatibility. (Fixes #848)
- Add the `?gemmtr_ `and `cblas_?gemmtr` aliases to symbol list.
- Also alias `cblas_?gemmt` as `cblas_?gemmtr` for lapack 3.12.1 compatibility.

(cherry picked from commit a6f2ce9)
devinamatthews pushed a commit that referenced this pull request Feb 5, 2025
@cdluminate @devinamatthews
Alias *gemmt_ as *gemmtr_ to fix lapack 3.12.1 compatibility. (#849)
8a287d5 
Details:
- Alias `?gemmt_` as `?gemmtr_` to fix lapack 3.12.1 compatibility. (Fixes #848)
- Add the `?gemmtr_ `and `cblas_?gemmtr` aliases to symbol list.
- Also alias `cblas_?gemmt` as `cblas_?gemmtr` for lapack 3.12.1 compatibility.

(cherry picked from commit a6f2ce9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdluminate @devinamatthews