feature(Partner SDK): Add V2 examples for SourceConnector #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fivetran-satvikpatil
requested review from
manjutapali and
fivetran-rishabhghosh
|
This pull request has been linked to 1 task:
|
fivetran-rishabhghosh
approved these changes
Jan 8, 2025
| @@ -36,7 +35,7 @@ func (s *server) Update(in *pb.UpdateRequest, stream pb.Connector_UpdateServer) | |||
| state := MyState{} | |||
| json.Unmarshal([]byte(state_json), &state) | |||
|
|
|||
| message := fmt.Sprintf("config: %s, selection: %s, state_json: %s, mystate: %s", config, selection, state_json, state) | |||
| message := fmt.Sprintf("config: %s, selection: %s, state_json: %s, mystate: %+v", config, selection, state_json, state) | |||
There was a problem hiding this comment.
%+v format specifier is used with the fmt to print the value of a struct with field names included.
We shouldn't use %s for it.
| } | ||
|
|
||
| message ConfigurationTest { | ||
| string name = 1; // unique identifier for the test |
There was a problem hiding this comment.
NIT: Remove the comments
added 9 commits
January 9, 2025 10:11
fivetran-satvikpatil
force-pushed
the
satvik/v2-source-examples
branch
from
282ca32 to
9646e4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link T-849690
Description
Added V2 examples for SourceConnector
Testing (Updating...)