-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(fivetran_sdk): Create a separate folder for V1 examples #79
refactor(fivetran_sdk): Create a separate folder for V1 examples #79
Conversation
This pull request has been linked to and will mark 1 task as "Done" when merged:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please update the github workflow, to ensure these examples are build/tested properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
Just one question:
- Once this PR is merged, I believe there is no change with testers and thus customers would not be affected?
@fivetran-rishabhghosh Yes, there are no changes in testers for now. The examples are working fine. This is not a problem for now, as I am not merging these changes in the main branch. We will be doing it later. |
@fivetran-satvikpatil @varundhall It is better we merge this to main branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI job is failing, please check it.
@varundhall I fixed argument issue, but now it is failing with another issue. Created a ticket to fix it: https://fivetran.height.app/T-860002 |
Closes T-859009
Description
Testing
Source
Destination