Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(partner_sdk): Alter Table operation guidelines #71

Merged
merged 4 commits into from
Oct 15, 2024
Merged

doc(partner_sdk): Alter Table operation guidelines #71

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83ce473
doc(partner_sdk): Alter Table operation guidelines
fivetran-rishabhghosh Oct 9, 2024
c11811e
Update development-guide.md
fivetran-rishabhghosh Oct 14, 2024
0420094
review comments
fivetran-rishabhghosh Oct 15, 2024
553689b
Update development-guide.md
fivetran-rishabhghosh Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions development-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,10 @@ This operation should report all columns in the destination table, including Fiv
- This operation might be requested for a table that does not exist in the destination. In that case, it should NOT fail, simply ignore the request and return `success = true`.
- `utc_delete_before` has millisecond precision.

#### AlterTable
- This operation should exercise change of primary key columns, addition of columns, change of data types, etc.
fivetran-rishabhghosh marked this conversation as resolved.
Show resolved Hide resolved
fivetran-rishabhghosh marked this conversation as resolved.
Show resolved Hide resolved
- However, this operation should not drop any columns even if the alter table request has a table with a different set of columns. Dropping of columns could lead to unexpected data loss for customers and is against Fivetran's general approach to data movement.
fivetran-rishabhghosh marked this conversation as resolved.
Show resolved Hide resolved

#### WriteBatchRequest
- `replace_files` is for the `upsert` operation where the rows should be inserted if they don't exist or updated if they do. Each row always provides values for all columns. Populate the `_fivetran_synced` column in the destination with the values coming in from the CSV files.

Expand Down
Loading