Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final mnemonic updates #774

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Final mnemonic updates #774

merged 1 commit into from
Nov 28, 2019

Conversation

riordant
Copy link
Contributor

@riordant riordant commented Nov 28, 2019 •
edited
Loading

PR intention

Finalize the mnemonic PR

Code changes brief

Mnemonic window:

  • change welcome text and height
  • checkbox for mnemonic passphrase + small explainer text
  • disallow empty passphrase when checkbox set
  • Clear text boxes when toggling

Backend:

  • handle conf file parameter interaction
  • block importing a dumpfile or a private key for mnemonic wallet
  • Update RPC tests to disable mnemonic by default

catchingknives
catchingknives approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@catchingknives catchingknives left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

levonpetrosyan93
levonpetrosyan93 reviewed Nov 28, 2019
View reviewed changes
Copy link
Contributor

@levonpetrosyan93 levonpetrosyan93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix failing RPC. Remaining looks good.

@riordant riordant merged commit 61a85ca into mnemonic Nov 28, 2019
@riordant riordant deleted the mnemonic_updates branch November 28, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levonpetrosyan93 levonpetrosyan93 levonpetrosyan93 left review comments

@catchingknives catchingknives catchingknives approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riordant @catchingknives @levonpetrosyan93