Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex AI] Replace legacy errors in GenerativeAIService #14036

Merged
merged 3 commits into from
Nov 5, 2024
Merged

[Vertex AI] Replace legacy errors in GenerativeAIService #14036

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e44bdba
[Vertex AI] Replace legacy errors in `GenerativeAIService`
andrewheard Nov 5, 2024
6d1f52f
Add `testGenerateContent_failure_nonHTTPResponse` assertions
andrewheard Nov 5, 2024
9d1fcfa
Add missing close quotation mark
andrewheard Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add missing close quotation mark
  • Loading branch information
@andrewheard
andrewheard committed Nov 5, 2024
commit 9d1fcfafab044c8ed59506fe14077cd34fff12a2
2 changes: 1 addition & 1 deletion FirebaseVertexAI/Sources/GenerativeAIService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ struct GenerativeAIService {
private func httpResponse(urlResponse: URLResponse) throws -> HTTPURLResponse {
// The following condition should always be true: "Whenever you make HTTP URL load requests, any
// response objects you get back from the URLSession, NSURLConnection, or NSURLDownload class
// are instances of the HTTPURLResponse class.
// are instances of the HTTPURLResponse class."
guard let response = urlResponse as? HTTPURLResponse else {
VertexLog.error(
code: .generativeAIServiceNonHTTPResponse,
Expand Down
Loading