Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix item validation #14896

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Conversation

dododedodonl
Copy link
Contributor

@dododedodonl dododedodonl commented Nov 27, 2024

Description

It is possible to set maxItems and minItems to null in

public function maxItems(int | Closure | null $count): static
Doing so, will break the validation rule (and throw an exception) as no int is provided.

Exception:

Brick\Math\BigNumber::isLessThanOrEqualTo(): Argument #1 ($that) must be of type Brick\Math\BigNumber|string|int|float, null given, called in vendor/laravel/framework/src/Illuminate/Validation/Concerns/ValidatesAttributes.php on line 1466

Visual changes

None

Functional changes

  • Code style has been fixed by running the composer cs command.
    • only fixed touched files
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added the bug Something isn't working label Nov 29, 2024
@danharrin danharrin added this to the v3 milestone Nov 29, 2024
@danharrin danharrin merged commit caff9ed into filamentphp:3.x Nov 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants