Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introducing OmitReadonly type to resolve required + readonly/writeonly properties #1145

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
update typescript and remove jest and angular
as this repository is only used for our ts code gen
  • Loading branch information
tiholic committed Nov 20, 2024
commit 727f32eae4643f383777b66694b9582926efe31d
31 changes: 1 addition & 30 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,31 +1,2 @@
# Contributing to Webpack Typings for JSON
# DURING RELEASE

Thanks for your interest in contributing to this project.

## Pull Request guidelines

Before working on a Pull Request, create an issue explaining what you want to contribute.
This ensures that your pull request won't go unnoticed, and that you are not contributing
something that is not suitable for the project.

If you are unfamiliar with GitHub Pull Requests, please read the following documentation:
https://help.github.com/articles/using-pull-requests

**Your Pull Request must:**

* Address a single issue or add a single item of functionality.
* Contain a clean history of small, incremental, logically separate commits, with no merge commits.
* Use clear commit messages.
* Be possible to merge automatically.

## Submitting a Pull Request

1. Make your changes in a new git branch: `git checkout -b my-fix-branch master`
2. Create your patch or feature
3. Ensure the builds work by running: `npm run build`
4. Ensure the tests will pass by running: `npm run test`
5. Ensure the code is formatted by running: `npm run eslint:fix`
6. Commit your changes using a descriptive commit message

After your Pull Request is created, it will automatically be build using Circle CI.
When the build is successful then the Pull Request is ready for review.
Loading