Remove the gc call in write.jl #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gc call was added in Windows only, apparently in response to issue #42. The consequence was that `writexlsx()` was much slower, with 97% of time spent on gc (in my use case). Deleting this line speeds up `writexlsx()` forty-fold and XLSX still passes all tests. Not sure what, if any, downsides there might be in other use cases.
|
Nice! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gc call was added in Windows only, apparently in response to issue #42.
The consequence was that
writexlsx()was much slower, with 97% of time spent on gc (in my use case).Deleting this line speeds up
writexlsx()forty-fold and XLSX still passes all tests.Not sure what, if any, downsides there might be in other use cases.
See this Discourse thread.