Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bloc)!: ignore emitted states after close is called #4337

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

felangel
Copy link
Owner

@felangel felangel commented Jan 15, 2025

Status

HOLD

Breaking Changes

YES

Description

  • feat(bloc)!: ignore emitted states after close is called

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added pkg:bloc This issue is related to the bloc package breaking change Enhancement candidate would introduce a breaking change labels Jan 15, 2025
@felangel felangel self-assigned this Jan 15, 2025
@felangel felangel linked an issue Jan 15, 2025 that may be closed by this pull request
@felangel felangel changed the title feat(bloc)!: ignore emitted states after close is called fix(bloc)!: ignore emitted states after close is called Jan 15, 2025
@felangel felangel marked this pull request as draft January 15, 2025 20:28
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.87%. Comparing base (14db8f3) to head (a040dce).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #4337      +/-   ##
===========================================
- Coverage   100.00%   99.87%   -0.13%     
===========================================
  Files           32       32              
  Lines          806      805       -1     
===========================================
- Hits           806      804       -2     
- Misses           0        1       +1     
Flag Coverage Δ
bloc 99.43% <100.00%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Enhancement candidate would introduce a breaking change pkg:bloc This issue is related to the bloc package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: emitting a state in a closed Cubit throws an error
1 participant