Support sequelize connection object (#388)

[Alfredo-Delgado]

• generate app
  • npm i feathers-cli
  • npm link generator-feathers
  • npx feathers generate app
• generate postgrs /src/sequelize.js
  • npm i feathers-cli
  • npm link generator-feathers
  • npx feathers generate connection #postgres
  • vim config/default.json # make postgres attribute an object
  • npx feathers generate service
    • curl new service 👍
  • npx feathers generate service
    • config/default.json isn't molested 👍
• generate mysql /src/sequelize.js
  • npm link generator-feathers
  • npx feathers generate connection #mysql
    • new template in effect 👍

Resolves #388

[daffl]

Thank you for the PR Alfredo. The problem with moving away from the connection string for all database adapters is that we now also have to document somewhere how the connection object looks like and where it can be modified since it is not something set up automatically by the generator.

Specifically for the problem in #388 and mentioned in feathersjs-ecosystem/feathers-sequelize#229 (comment) and in a discussion in feathersjs/feathers#676 (comment) a

encodeURIComponent('my@password') // -> 'my%40password'

Would also work. I know it's not super intuitive but connection strings are URIs after all.

[Alfredo-Delgado]

We can scrap this or I can look into getting the generator to ask which format to generate. I don't mind upgrading my nonexistent yeomen-fu.

[daffl]

A PR generally fancying up the connection setup would be great. Connection strings are definitely not super intuitive but it was the easiest (meaning me = laziest) way since it is just a single string prompt for every db.

[Alfredo-Delgado]

I'm currently leaving mssql out because I see that it has special handling where the connection string is broken out into components. Let me know if you think it makes sense to refactor that, too,

[Alfredo-Delgado]

e.g. force connection object on mssql and fold the sequelize-mssql.js template into the regular sequelize.js template.

[Alfredo-Delgado]

[daffl]

This looks great, thank you. Sorry I'm taking so long and now I even have to make another request 😑

This repo got moved to a monorepo at /~https://github.com/feathersjs/feathers. Would you mind reopening the pull request there (against /~https://github.com/feathersjs/feathers/tree/master/packages/generator-feathers)? I thought I could just import the new changes again but it does not seem to work.

[Alfredo-Delgado]

No problem.

[daffl]

Thank you! Closing this then.