Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share() fromEvent Observables #126

Merged
merged 1 commit into from
Jul 24, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import _debug from 'debug';

import { fromEvent } from 'rxjs';
import { share } from 'rxjs/operators';
import reactiveResource from './resource';
import reactiveList from './list';
import strategies from './strategies';
Expand Down Expand Up @@ -31,10 +32,10 @@ function FeathersRx (options = {}) {
// fromEvent's result selector (3rd arg) is deprecated
// we need it here because service events have an inconsistent number of arguments (i.e. sometimes 1, sometimes >1)
// related: /~https://github.com/ReactiveX/rxjs/issues/3751
created: fromEvent(service, 'created', (...args) => args[0]),
updated: fromEvent(service, 'updated', (...args) => args[0]),
patched: fromEvent(service, 'patched', (...args) => args[0]),
removed: fromEvent(service, 'removed', (...args) => args[0])
created: fromEvent(service, 'created', (...args) => args[0]).pipe(share()),
updated: fromEvent(service, 'updated', (...args) => args[0]).pipe(share()),
patched: fromEvent(service, 'patched', (...args) => args[0]).pipe(share()),
removed: fromEvent(service, 'removed', (...args) => args[0]).pipe(share())
};

// object to hold our reactive methods
Expand Down