Skip to content

Commit

Permalink
fix #111 (#113)
Browse files Browse the repository at this point in the history
* migrate to rxjs6

* fix imports for typings

* cosmetics...

* use fromEvent result selector, add comment re: result selector deprecation

* fix linting
  • Loading branch information
j2L4e authored and daffl committed May 26, 2018
1 parent 3482e20 commit 938ac3c
Showing 1 changed file with 7 additions and 5 deletions.
12 changes: 7 additions & 5 deletions src/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import _debug from 'debug';

import { fromEvent } from 'rxjs';
import { map } from 'rxjs/operators';
import reactiveResource from './resource';
import reactiveList from './list';
import strategies from './strategies';
Expand Down Expand Up @@ -29,10 +28,13 @@ function FeathersRx (options = {}) {
const app = this;

const events = {
created: fromEvent(service, 'created').pipe(map(event => event[0])),
updated: fromEvent(service, 'updated').pipe(map(event => event[0])),
patched: fromEvent(service, 'patched').pipe(map(event => event[0])),
removed: fromEvent(service, 'removed').pipe(map(event => event[0]))
// fromEvent's result selector (3rd arg) is deprecated
// we need it here because service events have an inconsistent number of arguments (i.e. sometimes 1, sometimes >1)
// related: /~https://github.com/ReactiveX/rxjs/issues/3751
created: fromEvent(service, 'created', (...args) => args[0]),
updated: fromEvent(service, 'updated', (...args) => args[0]),
patched: fromEvent(service, 'patched', (...args) => args[0]),
removed: fromEvent(service, 'removed', (...args) => args[0])
};

// object to hold our reactive methods
Expand Down

0 comments on commit 938ac3c

Please sign in to comment.