Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Check failed if the source file is empty #3

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Bug fix: Check failed if the source file is empty #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6570a44
Bug fix: Check failed if the source file is empty
leouieda Mar 1, 2024
b0221cd
Fix empty list check
leouieda Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions burocrata/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,12 @@ def main(extension, check, verbose, directory):
if gitignore.match_file(path):
continue
amount += 1
with open(path) as file:
for notice_line, file_line in zip(notice, file):
# Use [:-1] to strip the newline from the end
if notice_line != file_line[:-1]:
source_code = path.read_text().split("\n")
if not source_code:
missing_notice.append(path)
else:
for notice_line, file_line in zip(notice, source_code):
if notice_line != file_line:
missing_notice.append(path)
break
reporter.echo(
Expand Down