revert change to NewName being optional (we'll move to separate PR)

fastly/domain.go

@@ -151,7 +151,7 @@ type UpdateDomainInput struct {
 	Name string
 
 	// NewName is the updated name of the domain
-	NewName *string `form:"name,omitempty"`
+	NewName string `form:"name"`
 
 	// Comment is a personal, freeform descriptive note.
 	Comment *string `form:"comment,omitempty"`
@@ -172,10 +172,6 @@ func (c *Client) UpdateDomain(i *UpdateDomainInput) (*Domain, error) {
 		return nil, ErrMissingName
 	}
 
-	if i.NewName == nil && i.Comment == nil {
-		return nil, ErrMissingOptionalNameComment
-	}
-
 	path := fmt.Sprintf("/service/%s/version/%d/domain/%s", i.ServiceID, i.ServiceVersion, url.PathEscape(i.Name))
 	resp, err := c.PutForm(path, i, nil)
 	if err != nil {

fastly/domain_test.go

@@ -92,7 +92,7 @@ func TestClient_Domains(t *testing.T) {
 			ServiceID:      testServiceID,
 			ServiceVersion: tv.Number,
 			Name:           "integ-test.go-fastly.com",
-			NewName:        String("new-integ-test.go-fastly.com"),
+			NewName:        "new-integ-test.go-fastly.com",
 		})
 	})
 	if err != nil {
@@ -203,15 +203,6 @@ func TestClient_UpdateDomain_validation(t *testing.T) {
 	if err != ErrMissingName {
 		t.Errorf("bad error: %s", err)
 	}
-
-	_, err = testClient.UpdateDomain(&UpdateDomainInput{
-		ServiceID:      "foo",
-		ServiceVersion: 1,
-		Name:           "bar",
-	})
-	if err != ErrMissingOptionalNameComment {
-		t.Errorf("bad error: %s", err)
-	}
 }
 
 func TestClient_DeleteDomain_validation(t *testing.T) {