Add dynamic server support #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @devkitx thank you for taking your time to add this contribution, we really appreciate it. Unfortunately it seems @asobrien submitted a nearly identical PR (#142) a couple of days earlier than yours (which is pretty spooky), so if it's ok with you I'm going to close this one to avoid repetition and focus our efforts on that review? I'd really appreciate it if you could give that PR a review, so we can ensure you're also happy and it meets your companies needs/requirements. Once again, thank you for your contribution 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I have added pool and server functionality in order to support dynamic servers as outlined https://docs.fastly.com/api/dynamicservers. The tests for pool and server all pass with make test, with further testing being performed against live Fastly services that have dynamic servers enabled.
Please let me know if there are any changes as I am more than happy to iterate with this.
Thank you
Ed