Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: #5555 - move to node test runner #191

Merged
merged 9 commits into from
Feb 10, 2025
Merged

Test: #5555 - move to node test runner #191

merged 9 commits into from
Feb 10, 2025
+302 −244

Conversation

SamSalvatico
Copy link
Contributor

Checklist

Moving the tests from tap to the node test runner, based on what requested in the following issue
Fastify #5555

dancastillo
dancastillo reviewed Feb 8, 2025
View reviewed changes
Copy link
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update t.assert.equal to t.assert.strictEqual and t.assert.notEqual to t.assert.notStrictEqual

dancastillo
dancastillo approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@dancastillo dancastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsumners jsumners merged commit 0d9e5d4 into fastify:main Feb 10, 2025
11 checks passed
@SamSalvatico SamSalvatico deleted the test/move-to-node-test-runner branch February 10, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners approved these changes

@dancastillo dancastillo dancastillo approved these changes

@gurgunday gurgunday gurgunday approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SamSalvatico @jsumners @dancastillo @gurgunday