feat: add jsxAttributeCompletionStyle settings

microsoft/vscode#133920
fannheyward · Oct 11, 2021 · 9b913fc · 9b913fc
1 parent 5306fc3
commit 9b913fc
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 0 deletions.
diff --git a/package.json b/package.json
@@ -314,6 +314,22 @@
           "description": "Preferred path ending for auto imports.",
           "scope": "resource"
         },
+        "typescript.preferences.jsxAttributeCompletionStyle": {
+          "type": "string",
+          "enum": [
+            "auto",
+            "braces",
+            "none"
+          ],
+          "markdownEnumDescriptions": [
+            "Insert `={}` or `=\"\"` after attribute names based on the prop type.",
+            "Insert `={}` after attribute names.",
+            "Only insert attribute names."
+          ],
+          "default": "auto",
+          "description": "Preferred style for JSX attribute completions.",
+          "scope": "resource"
+        },
         "typescript.preferences.quoteStyle": {
           "type": "string",
           "default": "auto",
@@ -524,6 +540,22 @@
           "description": "Preferred path ending for auto imports.",
           "scope": "resource"
         },
+        "javascript.preferences.jsxAttributeCompletionStyle": {
+          "type": "string",
+          "enum": [
+            "auto",
+            "braces",
+            "none"
+          ],
+          "markdownEnumDescriptions": [
+            "Insert `={}` or `=\"\"` after attribute names based on the prop type.",
+            "Insert `={}` after attribute names.",
+            "Only insert attribute names."
+          ],
+          "default": "auto",
+          "description": "Preferred style for JSX attribute completions.",
+          "scope": "resource"
+        },
         "javascript.preferences.quoteStyle": {
           "type": "string",
           "default": "auto",

diff --git a/src/server/features/fileConfigurationManager.ts b/src/server/features/fileConfigurationManager.ts
@@ -176,6 +176,8 @@ export default class FileConfigurationManager {
       quotePreference: this.getQuoteStyle(config),
       importModuleSpecifierPreference: getImportModuleSpecifier(config) as any,
       importModuleSpecifierEnding: getImportModuleSpecifierEndingPreference(config),
+      // @ts-expect-error until TS 4.5 protocol update
+      jsxAttributeCompletionStyle: getJsxAttributeCompletionStyle(config),
       allowTextChangesInNewFiles: uri.startsWith('file:'),
       allowRenameOfImportPath: true,
       providePrefixAndSuffixTextForRename: config.get<boolean>('renameShorthandProperties', true) === false ? false : config.get<boolean>('useAliasesForRenames', true),
@@ -220,3 +222,11 @@ function getImportModuleSpecifierEndingPreference(config: WorkspaceConfiguration
     default: return 'auto'
   }
 }
+
+function getJsxAttributeCompletionStyle(config: WorkspaceConfiguration) {
+  switch (config.get<string>('jsxAttributeCompletionStyle')) {
+    case 'braces': return 'braces'
+    case 'none': return 'none'
+    default: return 'auto'
+  }
+}