new(falco): add base_syscalls.all option to replace -A #3352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea; let's deprecated yet another CLI option! |
LucaGuerra
force-pushed
the
new/base_syscalls_all_option
branch
2 times, most recently
from
2abd2db to
e4e41f8
Compare
LucaGuerra
changed the title
|
need to fix formatting / tests |
LucaGuerra
force-pushed
the
new/base_syscalls_all_option
branch
from
e4e41f8 to
f71fc81
Compare
LucaGuerra
changed the title
FedeDP
reviewed
Oct 1, 2024
There was a problem hiding this comment.
LGTM; same comment as #3362 (comment) applies here too; wdyt?
LucaGuerra
force-pushed
the
new/base_syscalls_all_option
branch
2 times, most recently
from
c7512e5 to
0198250
Compare
|
@FedeDP done! |
|
LGTM label has been added. Git tree hash: 82258bc679f56a392dfd9220b72876d49d50a99e
|
Signed-off-by: Luca Guerra <luca@guerra.sh>
Signed-off-by: Luca Guerra <luca@guerra.sh>
LucaGuerra
force-pushed
the
new/base_syscalls_all_option
branch
from
0198250 to
a208172
Compare
sgaist
approved these changes
Oct 10, 2024
|
LGTM label has been added. Git tree hash: e8d5943a7b584ccb53381844e70f19223cf91c6a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
This adds
base_syscalls.allreplacing-A.This PR has not yet been linted. If the lint PR is merged I will update.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: