Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #3135 "fix(engine): apply output substitutions for all sources" #3236

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

mrgian
Copy link
Contributor

@mrgian mrgian commented Jun 4, 2024

This reverts commit 4ef7c95.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area engine

/area tests

/area proposals

/area CI

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix(engine): enable output substitution only for syscall rules, prevent engine from exiting with validation errors when a plugin is loaded and -pc/pk is specified

This reverts commit 4ef7c95.

Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
Copy link

github-actions bot commented Jun 4, 2024

This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped.

Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION.

/hold

@poiana
Copy link
Contributor

poiana commented Jun 4, 2024

LGTM label has been added.

Git tree hash: 5c7fa503738a4da502c06a89a6780cc0ed33844a

@poiana poiana added the approved label Jun 4, 2024
@leogr
Copy link
Member

leogr commented Jun 4, 2024

/milestone 0.38.1

@poiana poiana added this to the 0.38.1 milestone Jun 4, 2024
@leogr
Copy link
Member

leogr commented Jun 4, 2024

@LucaGuerra side note: we should also officially document that -pk (and other presets) works with syscalls source only

@FedeDP
Copy link
Contributor

FedeDP commented Jun 4, 2024

Side note: engine is not crashing but is triggering a validation exception :)

@LucaGuerra
Copy link
Contributor

#3238

@poiana
Copy link
Contributor

poiana commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, LucaGuerra, mrgian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LucaGuerra
Copy link
Contributor

/unhold

@poiana poiana merged commit 1c66b64 into falcosecurity:master Jun 5, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants