-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #3135 "fix(engine): apply output substitutions for all sources" #3236
Conversation
This reverts commit 4ef7c95. Signed-off-by: Gianmatteo Palmieri <mail@gian.im>
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
LGTM label has been added. Git tree hash: 5c7fa503738a4da502c06a89a6780cc0ed33844a
|
/milestone 0.38.1 |
@LucaGuerra side note: we should also officially document that |
Side note: engine is not crashing but is triggering a validation exception :) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, LucaGuerra, mrgian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
This reverts commit 4ef7c95.
What type of PR is this?
Any specific area of the project related to this PR?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: