Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: action naming #33

Merged
merged 18 commits into from
Jun 23, 2020
Merged

refactor: action naming #33

merged 18 commits into from
Jun 23, 2020

Conversation

leogr
Copy link
Member

@leogr leogr commented Jun 23, 2020

What type of PR is this?

/kind bug

/kind cleanup

/kind documentation

Any specific area of the project related to this PR?

/area events

What this PR does / why we need it:

This PR ensures that all action's names are following the naming convention as described here.

It will allow to automatically match the rule name as needed by #31

Special notes for your reviewer:

These changes were originally included in #31 ( I'm going to remove these from #31 as soon as this PR gets merged ).

/cc @leodido
/cc @fntlnz

Does this PR introduce a user-facing change?:

update(events/k8saudit): action renamed to `CreateDisallowedPod`
update(events/k8saudit): action renamed to `K8SServiceaccountCreated`
update(events/k8saudit): action renamed to `K8SServiceCreated`
update(events/k8saudit): action renamed to `K8SDeploymentCreated`
update(events/k8saudit): action renamed to `K8SConfigMapCreated`
update(events/k8saudit): action renamed to `CreateSensitiveMountPod`
update(events/k8saudit): action renamed to `CreatePrivilegedPod`
update(events/k8saudit): action renamed to `CreateNodePortService`
update(events/k8saudit): action renamed to `CreateHostNetworkPod`
update(events/k8saudit): action renamed to `CreateModifyConfigmapWithPrivateCredentials`
update(events/k8saudit): action renamed to `ClusterRoleWithWritePrivilegesCreated`
update(events/k8saudit): action renamed to `ClusterRoleWithWildcardCreated`
update(events/k8saudit): action renamed to `ClusterRoleWithPodExecCreated`
update(events/syscall): action renamed to `ReadSensitiveFileTrustedAfterStartup`
update(events/syscall): action renamed to `ReadSensitiveFileUntrusted`
update(events/syscall): action renamed to `DbProgramSpawnedProcess`
docs(events): improve naming convention
docs: update actions list

leogr added 18 commits June 23, 2020 10:54
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…terStartup`

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…ated`

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…eated`

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…legesCreated`

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…PrivateCredentials`

Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Copy link
Member

@leodido leodido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poiana
Copy link

poiana commented Jun 23, 2020

LGTM label has been added.

Git tree hash: d4d32b8ad2006b835b7963c334574d379dfaf3a4

@poiana
Copy link

poiana commented Jun 23, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leodido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit ac35210 into master Jun 23, 2020
@poiana poiana deleted the refactor/action-naming branch June 23, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants