-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: action naming #33
Conversation
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…terStartup` Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…ated` Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…eated` Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…legesCreated` Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
…PrivateCredentials` Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM label has been added. Git tree hash: d4d32b8ad2006b835b7963c334574d379dfaf3a4
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leodido The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind cleanup
/kind documentation
Any specific area of the project related to this PR?
/area events
What this PR does / why we need it:
This PR ensures that all action's names are following the naming convention as described here.
It will allow to automatically match the rule name as needed by #31
Special notes for your reviewer:
These changes were originally included in #31 ( I'm going to remove these from #31 as soon as this PR gets merged ).
/cc @leodido
/cc @fntlnz
Does this PR introduce a user-facing change?: