-
-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(locales): fix chemical element names in zh_CN #3371
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the old values were of by one.
Nicely spotted.
Any additional translations are welcome. If you keep the locale additions/changes to a single category/module (airline, science, word), then this helps with reviewing. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3371 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2811 2811
Lines 217023 217023
Branches 942 941 -1
=======================================
+ Hits 216970 216972 +2
+ Misses 53 51 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in case someone else need an external source to cross compare the values: https://en.wikipedia.org/wiki/Template:Periodic_table_(Chinese_names)
In the current locale, some simplified Chinese translations have issues. I will fix them in this PR.
BTW, is it better to translate more content? For example, aireline, commerce or others. If so, I would be interested in adding more fake data related to Simplified and Traditional Chinese.