Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locales): fix chemical element names in zh_CN #3371

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

tuanzisama
Copy link
Contributor

In the current locale, some simplified Chinese translations have issues. I will fix them in this PR.

BTW, is it better to translate more content? For example, aireline, commerce or others. If so, I would be interested in adding more fake data related to Simplified and Traditional Chinese.

@tuanzisama tuanzisama requested a review from a team as a code owner January 13, 2025 14:13
Copy link

netlify bot commented Jan 13, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 4507f22
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67852eb70ea00400085c5952
😎 Deploy Preview https://deploy-preview-3371.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the old values were of by one.
Nicely spotted.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: science Something is referring to the science module labels Jan 13, 2025
@ST-DDT ST-DDT added this to the vAnytime milestone Jan 13, 2025
@ST-DDT ST-DDT requested review from a team January 13, 2025 14:27
@ST-DDT
Copy link
Member

ST-DDT commented Jan 13, 2025

BTW, is it better to translate more content? For example, aireline, commerce or others. If so, I would be interested in adding more fake data related to Simplified and Traditional Chinese.

Any additional translations are welcome. If you keep the locale additions/changes to a single category/module (airline, science, word), then this helps with reviewing.

/~https://github.com/faker-js/faker/blob/next/CONTRIBUTING.md#adding-new-locale-or-updating-existing-one

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (bddce72) to head (4507f22).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3371   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2811     2811           
  Lines      217023   217023           
  Branches      942      941    -1     
=======================================
+ Hits       216970   216972    +2     
+ Misses         53       51    -2     
Files with missing lines Coverage Δ
src/locales/zh_CN/science/chemical_element.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case someone else need an external source to cross compare the values: https://en.wikipedia.org/wiki/Template:Periodic_table_(Chinese_names)

@ST-DDT ST-DDT changed the title fix(locales): update chemical element names in zh_CN refactor(locales): update chemical element names in zh_CN Jan 15, 2025
@ST-DDT ST-DDT changed the title refactor(locales): update chemical element names in zh_CN refactor(locales): fix chemical element names in zh_CN Jan 15, 2025
@ST-DDT ST-DDT added this pull request to the merge queue Jan 15, 2025
Merged via the queue into faker-js:next with commit 6ec6f84 Jan 15, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: science Something is referring to the science module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants