Make ethtool optional in sample
#8211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure newer versions of below play nicely with older.
facebook-github-bot
added
the
CLA Signed
|
@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@brianc118 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@brianc118 merged this pull request in 22d9b41. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure newer versions of below play nicely with older.
Currently, on using newer version of below to parse snapshots recorded by earlier versions, it fails with error:
This change makes sure, error isn't thrown and
ethtoolis set asNonein the sample.