Add test logic to test events when rendering on top of SSR markup #6668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…top of server-generated markup.
ghost
added
|
Thanks Sasha! |
zpao
pushed a commit
to zpao/react
that referenced
this pull request
Jun 8, 2016
…top of server-generated markup. (facebook#6668) (cherry picked from commit 256753b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the middle of working on #6618, I broke all events when rendering on top of server-generated markup, but no unit test failed. I looked into it, and I think that there is a test case that is intended to test this, but it has a bug. This PR attempts to fix that.
The test
should have the correct mounting behaviorinReactServerRendering-test.jsruns through a bunch of cases with client rendering and server-generated markup, and at the end, it tests a simple click event to make sure that events work on the client. Unfortunately, what it does right before that is test out a markup mismatch. This means that the client-generated rendering at that point did not actually follow the SSR code path; it found a checksum mismatch and then followed the non-SSR/useCreateElement code path.This is a pretty simple PR that tests the click event after the test renders on top of server-generated markup and doesn't get a markup mismatch.
Thanks!