fix(fast-refresh): fix #20417 #21074
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no signatures on both sides, consider as not equal signature, forcing remount and not refresh
|
Comparing: 7b84dbd...856e5e2 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
gaearon
reviewed
Mar 24, 2021
| @@ -128,7 +128,7 @@ function haveEqualSignatures(prevType, nextType) { | |||
| const nextSignature = allSignaturesByType.get(nextType); | |||
|
|
|||
| if (prevSignature === undefined && nextSignature === undefined) { | |||
| return true; | |||
| return false; | |||
There was a problem hiding this comment.
This change would cause every component without Hooks to always be remounted. That's not right.
|
The current behavior is correct. #20417 (comment) |
|
This was a draft PR on purpose, for the CI to run, |
|
Yeah I assumed that the issue is already solved in which case PR isn't needed. But like I mentioned on the issue, it seems like my analysis wasn't right. So feel free to keep exploring. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no signatures on both sides, consider as not equal signature,
forcing remount and not refresh
Summary
Test Plan