Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RetryLanes instead of event time (follow up) #19335

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Use RetryLanes instead of event time (follow up) #19335

merged 1 commit into from
Jul 13, 2020

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jul 13, 2020

Same logic as #19307. Uses RetryLanes instead of event time to determine if a render includes new updates.

@acdlite
Use RetryLanes instead of event time (follow up)
11b62a6 
Same logic as facebook#19307. Uses RetryLanes instead of event time to
determine if a render includes new updates.
@acdlite acdlite requested review from gaearon and rickhanlonii July 13, 2020 17:26
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 13, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 11b62a6:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jul 13, 2020

Details of bundled changes.

Comparing: fe19b42...11b62a6

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.0% -0.1% 913.67 KB 913.35 KB 207.69 KB 207.57 KB NODE_DEV
ReactDOMForked-prod.js 0.0% 0.0% 393.41 KB 393.44 KB 73.23 KB 73.24 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% -0.0% 138.84 KB 138.84 KB 36.68 KB 36.68 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 123.7 KB 123.71 KB 39.65 KB 39.64 KB NODE_PROD
ReactDOMForked-profiling.js 0.0% 0.0% 404.03 KB 404.06 KB 74.97 KB 74.98 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 145.04 KB 145.04 KB 36.88 KB 36.88 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.71 KB 20.71 KB 7.67 KB 7.67 KB NODE_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 10.35 KB 10.35 KB 4.07 KB 4.07 KB UMD_PROD
ReactDOMTesting-dev.js -0.0% -0.1% 953.59 KB 953.26 KB 213.72 KB 213.6 KB FB_WWW_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 398.94 KB 398.97 KB 75.46 KB 75.47 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.61 KB 5.61 KB 1.87 KB 1.86 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.2 KB 10.2 KB 3.99 KB 3.99 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.17 KB 1.17 KB 667 B 665 B NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.2 KB 1.2 KB 706 B 705 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.87 KB 4.87 KB 1.71 KB 1.7 KB NODE_DEV
react-dom.development.js -0.0% -0.1% 959.7 KB 959.36 KB 210.21 KB 210.08 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.01 KB 1.01 KB 617 B 615 B NODE_PROD
react-dom.production.min.js 0.0% 0.0% 123.52 KB 123.53 KB 40.44 KB 40.44 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 127.47 KB 127.48 KB 41.65 KB 41.64 KB UMD_PROFILING
ReactDOMForked-dev.js -0.0% -0.1% 974.97 KB 974.65 KB 217.91 KB 217.79 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% 0.0% 127.82 KB 127.83 KB 40.9 KB 40.9 KB NODE_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 20.37 KB 20.37 KB 7.54 KB 7.54 KB UMD_PROD
ReactDOM-dev.js -0.0% -0.1% 988.89 KB 988.57 KB 220.16 KB 220.04 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 398.35 KB 398.38 KB 74.22 KB 74.22 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 137.57 KB 137.57 KB 36.43 KB 36.43 KB NODE_DEV
ReactDOM-profiling.js 0.0% 0.0% 408.97 KB 409.01 KB 75.96 KB 75.97 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 20.29 KB 20.29 KB 7.52 KB 7.52 KB NODE_PROD
ReactDOMServer-dev.js 0.0% -0.0% 143.41 KB 143.41 KB 36.44 KB 36.44 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 46.7 KB 46.7 KB 10.92 KB 10.92 KB FB_WWW_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.0% -0.1% 685.31 KB 684.99 KB 148.32 KB 148.19 KB RN_FB_DEV
ReactFabric-dev.js -0.0% -0.1% 666.03 KB 665.71 KB 143.63 KB 143.51 KB RN_FB_DEV
ReactNativeRenderer-dev.js -0.0% -0.1% 679.92 KB 679.59 KB 147.48 KB 147.34 KB RN_OSS_DEV
ReactFabric-prod.js 0.0% 0.0% 265.26 KB 265.3 KB 46.98 KB 46.99 KB RN_FB_PROD
ReactNativeRenderer-prod.js 0.0% 0.0% 271.59 KB 271.62 KB 48.29 KB 48.29 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 276.76 KB 276.8 KB 49.18 KB 49.19 KB RN_FB_PROFILING
ReactNativeRenderer-profiling.js 0.0% 0.0% 283.06 KB 283.09 KB 50.47 KB 50.48 KB RN_OSS_PROFILING
ReactNativeRenderer-prod.js 0.0% 0.0% 271.54 KB 271.58 KB 48.27 KB 48.28 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 283.01 KB 283.04 KB 50.45 KB 50.46 KB RN_FB_PROFILING
ReactFabric-dev.js -0.0% -0.1% 660.63 KB 660.31 KB 142.78 KB 142.66 KB RN_OSS_DEV
ReactFabric-prod.js 0.0% 0.0% 265.3 KB 265.33 KB 47 KB 47 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 276.8 KB 276.84 KB 49.2 KB 49.21 KB RN_OSS_PROFILING

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js 0.0% 0.0% 244.74 KB 244.77 KB 43.41 KB 43.42 KB FB_WWW_PROD
react-art.development.js -0.0% -0.1% 689.4 KB 689.06 KB 146.13 KB 146.01 KB UMD_DEV
react-art.production.min.js 0.0% 0.0% 112.57 KB 112.58 KB 34.86 KB 34.86 KB UMD_PROD
react-art.development.js -0.1% -0.1% 590.83 KB 590.5 KB 128.32 KB 128.2 KB NODE_DEV
react-art.production.min.js 0.0% 0.0% 77.47 KB 77.48 KB 23.94 KB 23.94 KB NODE_PROD
ReactART-dev.js -0.1% -0.1% 628.25 KB 627.92 KB 133.39 KB 133.27 KB FB_WWW_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 12.74 KB 12.74 KB 3.97 KB 3.97 KB UMD_PROD
react-test-renderer.development.js -0.1% -0.1% 605.55 KB 605.22 KB 127.3 KB 127.18 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 76.75 KB 76.75 KB 24.02 KB 24.01 KB UMD_PROD
react-test-renderer.development.js -0.1% -0.1% 576.93 KB 576.6 KB 125.86 KB 125.73 KB NODE_DEV
react-test-renderer.production.min.js 0.0% -0.0% 76.56 KB 76.57 KB 23.71 KB 23.71 KB NODE_PROD
ReactTestRenderer-dev.js -0.1% -0.1% 599.97 KB 599.64 KB 128.66 KB 128.53 KB FB_WWW_DEV
ReactTestRenderer-dev.js -0.1% -0.1% 593.21 KB 592.89 KB 128.44 KB 128.31 KB RN_FB_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 39.17 KB 39.17 KB 9.58 KB 9.58 KB UMD_DEV

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js -0.0% -0.1% 650.57 KB 650.25 KB 138.69 KB 138.57 KB NODE_DEV
react-reconciler-reflection.development.js 0.0% -0.0% 16.71 KB 16.71 KB 4.98 KB 4.98 KB NODE_DEV
react-reconciler.production.min.js 0.0% -0.0% 87.58 KB 87.58 KB 26.84 KB 26.84 KB NODE_PROD
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.81 KB 2.81 KB 1.16 KB 1.16 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against 11b62a6

@sizebot
Copy link

sizebot commented Jul 13, 2020

Details of bundled changes.

Comparing: fe19b42...11b62a6

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js -0.0% -0.1% 881.14 KB 880.81 KB 201.81 KB 201.68 KB NODE_DEV
ReactDOMForked-prod.js 0.0% 0.0% 404.53 KB 404.56 KB 74.75 KB 74.76 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% -0.0% 137.33 KB 137.33 KB 36.47 KB 36.47 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 118.95 KB 118.96 KB 38.24 KB 38.23 KB NODE_PROD
ReactDOMForked-profiling.js 0.0% 0.0% 415.21 KB 415.25 KB 76.51 KB 76.51 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 143.45 KB 143.45 KB 36.68 KB 36.68 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.25 KB 20.25 KB 7.6 KB 7.6 KB NODE_PROD
ReactDOMTesting-dev.js -0.0% -0.1% 981.72 KB 981.39 KB 219.61 KB 219.5 KB FB_WWW_DEV
ReactDOMTesting-prod.js 0.0% 0.0% 412.31 KB 412.34 KB 77.37 KB 77.37 KB FB_WWW_PROD
react-dom.development.js -0.0% -0.1% 925.72 KB 925.38 KB 204.21 KB 204.09 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 118.83 KB 118.84 KB 39.01 KB 39.02 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 122.74 KB 122.75 KB 40.16 KB 40.16 KB UMD_PROFILING
ReactDOMForked-dev.js -0.0% -0.1% 1000.51 KB 1000.18 KB 223.11 KB 223 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% -0.0% 123 KB 123.01 KB 39.45 KB 39.44 KB NODE_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 19.91 KB 19.91 KB 7.46 KB 7.46 KB UMD_PROD
ReactDOM-dev.js -0.0% -0.1% 1014.42 KB 1014.1 KB 225.35 KB 225.24 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 409.47 KB 409.51 KB 75.74 KB 75.75 KB FB_WWW_PROD
react-dom-server.browser.development.js 0.0% -0.0% 136.06 KB 136.06 KB 36.22 KB 36.22 KB NODE_DEV
ReactDOM-profiling.js 0.0% 0.0% 420.16 KB 420.19 KB 77.5 KB 77.5 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 19.83 KB 19.83 KB 7.44 KB 7.44 KB NODE_PROD
ReactDOMServer-dev.js 0.0% -0.0% 147.44 KB 147.44 KB 37.44 KB 37.44 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% -0.0% 47.56 KB 47.56 KB 11.14 KB 11.14 KB FB_WWW_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-prod.js 0.0% 0.0% 251.88 KB 251.91 KB 44.69 KB 44.7 KB FB_WWW_PROD
react-art.development.js -0.0% -0.1% 667 KB 666.66 KB 141.98 KB 141.86 KB UMD_DEV
react-art.production.min.js 0.0% 0.0% 109.6 KB 109.61 KB 33.96 KB 33.96 KB UMD_PROD
react-art.development.js -0.1% -0.1% 569.35 KB 569.02 KB 124.23 KB 124.1 KB NODE_DEV
react-art.production.min.js 0.0% 0.0% 74.56 KB 74.57 KB 23.06 KB 23.06 KB NODE_PROD
ReactART-dev.js -0.1% -0.1% 638.26 KB 637.94 KB 135.42 KB 135.3 KB FB_WWW_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 12.73 KB 12.73 KB 3.96 KB 3.96 KB UMD_PROD
react-test-renderer.development.js -0.1% -0.1% 605.52 KB 605.19 KB 127.29 KB 127.17 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 76.72 KB 76.73 KB 24 KB 24 KB UMD_PROD
react-test-renderer.development.js -0.1% -0.1% 576.9 KB 576.58 KB 125.84 KB 125.72 KB NODE_DEV
react-test-renderer.production.min.js 0.0% -0.0% 76.54 KB 76.55 KB 23.69 KB 23.69 KB NODE_PROD
ReactTestRenderer-dev.js -0.1% -0.1% 599.96 KB 599.63 KB 128.65 KB 128.52 KB FB_WWW_DEV
ReactTestRenderer-dev.js -0.1% -0.1% 593.2 KB 592.87 KB 128.43 KB 128.31 KB RN_FB_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 39.16 KB 39.16 KB 9.57 KB 9.57 KB UMD_DEV

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js -0.0% -0.1% 679.91 KB 679.58 KB 147.47 KB 147.33 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 0.0% 0.0% 271.57 KB 271.61 KB 48.28 KB 48.29 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 283.04 KB 283.08 KB 50.46 KB 50.47 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.0% -0.1% 660.62 KB 660.29 KB 142.78 KB 142.65 KB RN_OSS_DEV
ReactFabric-prod.js 0.0% 0.0% 265.29 KB 265.32 KB 46.99 KB 47 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 276.79 KB 276.82 KB 49.2 KB 49.2 KB RN_OSS_PROFILING

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js -0.1% -0.1% 626.73 KB 626.41 KB 134.13 KB 134 KB NODE_DEV
react-reconciler.production.min.js 0.0% 0.0% 84.22 KB 84.23 KB 25.91 KB 25.91 KB NODE_PROD
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.8 KB 2.8 KB 1.15 KB 1.15 KB NODE_PROD

Size changes (stable)

Generated by 🚫 dangerJS against 11b62a6

rickhanlonii
rickhanlonii approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acdlite acdlite merged commit d1f2143 into facebook:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

@gaearon gaearon Awaiting requested review from gaearon

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acdlite @sizebot @rickhanlonii @facebook-github-bot