Skip to content

Commit

Permalink
[ci] Fix maintainer output condition check (#32111)
Browse files Browse the repository at this point in the history
It appears GH actions treats outputs from workflow_calls to [always be
strings](/~https://github.com/orgs/community/discussions/9343) so we need
to do an explicit comparison.
  • Loading branch information
poteto authored Jan 17, 2025
1 parent 5f38ef6 commit d46b04a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/compiler_discord_notify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main

notify:
if: ${{ needs.check_maintainer.outputs.is_core_team }}
if: ${{ needs.check_maintainer.outputs.is_core_team == 'true' }}
needs: check_maintainer
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/runtime_discord_notify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main

notify:
if: ${{ needs.check_maintainer.outputs.is_core_team }}
if: ${{ needs.check_maintainer.outputs.is_core_team == 'true' }}
needs: check_maintainer
runs-on: ubuntu-latest
steps:
Expand Down

0 comments on commit d46b04a

Please sign in to comment.