skip null ref warning for ReactTestRenderer

Only instances created with ReactTestRenderer have a toJSON method
facebook · Sep 5, 2016 · b89824f · b89824f
1 parent 6a525fd
commit b89824f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/renderers/shared/stack/reconciler/ReactCompositeComponent.js b/src/renderers/shared/stack/reconciler/ReactCompositeComponent.js
@@ -1107,7 +1107,7 @@ var ReactCompositeComponent = {
     if (__DEV__) {
       var componentName = component && component.getName ?
         component.getName() : 'a component';
-      warning(publicComponentInstance != null,
+      warning(publicComponentInstance != null || component.toJSON,
         'Stateless function components cannot be given refs ' +
         '(See ref "%s" in %s created by %s). ' +
         'Attempts to access this ref will fail.',

diff --git a/src/renderers/testing/__tests__/ReactTestRenderer-test.js b/src/renderers/testing/__tests__/ReactTestRenderer-test.js
@@ -206,6 +206,17 @@ describe('ReactTestRenderer', function() {
     expect(log).toEqual([null]);
   });
 
+  it('does not warn with legacy refs', function() {
+    spyOn(console, 'error');
+    class Foo extends React.Component {
+      render() {
+        return <div ref="foo" />
+      }
+    }
+    ReactTestRenderer.create(<Foo />);
+    expect(console.error.calls.count()).toBe(0);
+  });
+
   it('supports error boundaries', function() {
     var log = [];
     class Angry extends React.Component {