-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added aria-modal as alias for accessibilityViewIsModal(iOS) #34506
Changes from 10 commits
91a4124
04cf3c9
d708cfe
75e405c
ce50c93
1255ab8
1e52fe6
97fbf1c
6f5e29b
13b5e10
ad116e0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -164,7 +164,11 @@ class TouchableBounce extends React.Component<Props, State> { | |||||||||
? 'no-hide-descendants' | ||||||||||
: this.props.importantForAccessibility | ||||||||||
} | ||||||||||
accessibilityViewIsModal={this.props.accessibilityViewIsModal} | ||||||||||
accessibilityViewIsModal={ | ||||||||||
this.props['aria-modal'] !== null | ||||||||||
? this.props['aria-modal'] | ||||||||||
: this.props.accessibilityViewIsModal | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
} | ||||||||||
accessibilityElementsHidden={ | ||||||||||
this.props['aria-hidden'] ?? this.props.accessibilityElementsHidden | ||||||||||
} | ||||||||||
|
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -310,8 +310,12 @@ class TouchableHighlight extends React.Component<Props, State> { | |||||||||
? 'no-hide-descendants' | ||||||||||
: this.props.importantForAccessibility | ||||||||||
} | ||||||||||
accessibilityViewIsModal={ | ||||||||||
this.props['aria-modal'] !== null | ||||||||||
? this.props['aria-modal'] | ||||||||||
: this.props.accessibilityViewIsModal | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
} | ||||||||||
accessibilityLiveRegion={accessibilityLiveRegion} | ||||||||||
accessibilityViewIsModal={this.props.accessibilityViewIsModal} | ||||||||||
accessibilityElementsHidden={ | ||||||||||
this.props['aria-hidden'] ?? this.props.accessibilityElementsHidden | ||||||||||
} | ||||||||||
|
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -301,8 +301,11 @@ class TouchableNativeFeedback extends React.Component<Props, State> { | |||||||||
this.props['aria-hidden'] === true | ||||||||||
? 'no-hide-descendants' | ||||||||||
: this.props.importantForAccessibility, | ||||||||||
accessibilityViewIsModal: | ||||||||||
this.props['aria-modal'] !== null | ||||||||||
? this.props['aria-modal'] | ||||||||||
: this.props.accessibilityViewIsModal, | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
accessibilityLiveRegion: accessibilityLiveRegion, | ||||||||||
accessibilityViewIsModal: this.props.accessibilityViewIsModal, | ||||||||||
accessibilityElementsHidden: | ||||||||||
this.props['aria-hidden'] ?? this.props.accessibilityElementsHidden, | ||||||||||
hasTVPreferredFocus: this.props.hasTVPreferredFocus, | ||||||||||
|
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -256,8 +256,12 @@ class TouchableOpacity extends React.Component<Props, State> { | |||||||||
? 'no-hide-descendants' | ||||||||||
: this.props.importantForAccessibility | ||||||||||
} | ||||||||||
accessibilityViewIsModal={ | ||||||||||
this.props['aria-modal'] !== null | ||||||||||
? this.props['aria-modal'] | ||||||||||
: this.props.accessibilityViewIsModal | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
} | ||||||||||
accessibilityLiveRegion={accessibilityLiveRegion} | ||||||||||
accessibilityViewIsModal={this.props.accessibilityViewIsModal} | ||||||||||
accessibilityElementsHidden={ | ||||||||||
this.props['aria-hidden'] ?? this.props.accessibilityElementsHidden | ||||||||||
} | ||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.