-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blob] Release underlying resources when JS instance in GC'ed on iOS #24405
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| #import <jsi/jsi.h> | ||
|
|
||
| using namespace facebook; | ||
|
|
||
| @class RCTBlobManager; | ||
|
|
||
| namespace facebook { | ||
| namespace react { | ||
|
|
||
| class JSI_EXPORT RCTBlobCollector : public jsi::HostObject { | ||
| public: | ||
| RCTBlobCollector(RCTBlobManager *blobManager, const std::string &blobId); | ||
| ~RCTBlobCollector(); | ||
|
|
||
| static void install(RCTBlobManager *blobManager); | ||
|
|
||
| private: | ||
| const std::string blobId_; | ||
| RCTBlobManager *blobManager_; | ||
| }; | ||
|
|
||
| } // namespace react | ||
| } // namespace facebook |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /** | ||
| * Copyright (c) Facebook, Inc. and its affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| #import "RCTBlobCollector.h" | ||
|
|
||
| #import <React/RCTBridge+Private.h> | ||
| #import "RCTBlobManager.h" | ||
|
|
||
| namespace facebook { | ||
| namespace react { | ||
|
|
||
| RCTBlobCollector::RCTBlobCollector(RCTBlobManager *blobManager, const std::string &blobId) | ||
| : blobId_(blobId), blobManager_(blobManager) {} | ||
|
|
||
| RCTBlobCollector::~RCTBlobCollector() { | ||
| RCTBlobManager *blobManager = blobManager_; | ||
| NSString *blobId = [NSString stringWithUTF8String:blobId_.c_str()]; | ||
| dispatch_async([blobManager_ methodQueue], ^{ | ||
| [blobManager remove:blobId]; | ||
| }); | ||
| } | ||
|
|
||
| void RCTBlobCollector::install(RCTBlobManager *blobManager) { | ||
| __weak RCTCxxBridge *cxxBridge = (RCTCxxBridge *)blobManager.bridge; | ||
| [cxxBridge dispatchBlock:^{ | ||
| if (!cxxBridge || cxxBridge.runtime == nullptr) { | ||
| return; | ||
| } | ||
| jsi::Runtime &runtime = *(jsi::Runtime *)cxxBridge.runtime; | ||
| runtime.global().setProperty( | ||
| runtime, | ||
| "__blobCollectorProvider", | ||
| jsi::Function::createFromHostFunction( | ||
| runtime, | ||
| jsi::PropNameID::forAscii(runtime, "__blobCollectorProvider"), | ||
| 1, | ||
| [blobManager](jsi::Runtime& rt, const jsi::Value& thisVal, const jsi::Value* args, size_t count) { | ||
| auto blobId = args[0].asString(rt).utf8(rt); | ||
| auto blobCollector = std::make_shared<RCTBlobCollector>(blobManager, blobId); | ||
| return jsi::Object::createFromHostObject(rt, blobCollector); | ||
| } | ||
| ) | ||
| ); | ||
| } queue:RCTJSThread]; | ||
| } | ||
|
|
||
| } // namespace react | ||
| } // namespace facebook | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of doing this dance of using blobId as string, then asking nativemodule to clean it up, it's probably better long term to send down direct pointer to a blob (as jsi::Value) to JS, which can get cleaned up automatically by the JS runtime. See Fabric's UIManager method/impl as an example.