reap gen_multiple and replace with gen_for_multiple_with_multiple #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67319697 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 27, 2025
…cebook#3436) Summary: This diff removes _gen_multiple and replaces it with calls to gen_for_multiple_with_multiple. We plan to replace gen() with gen_for_multiple_with_multiple() with the Ax1.0 release so will keep both around for now. Internal - Tldr: {F1973912988} See diff 1/n in the stack for context Reviewed By: saitcakmak Differential Revision: D67319697
lena-kashtelyan
force-pushed
the
export-D67319697
branch
from
93d0a5c to
8ca6593
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67319697 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 27, 2025
…cebook#3436) Summary: Pull Request resolved: facebook#3436 This diff removes _gen_multiple and replaces it with calls to gen_for_multiple_with_multiple. We plan to replace gen() with gen_for_multiple_with_multiple() with the Ax1.0 release so will keep both around for now. Internal - Tldr: {F1973912988} See diff 1/n in the stack for context Reviewed By: saitcakmak Differential Revision: D67319697
lena-kashtelyan
force-pushed
the
export-D67319697
branch
from
8ca6593 to
6b66027
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3436 +/- ##
=======================================
Coverage 95.99% 96.00%
=======================================
Files 539 539
Lines 52850 52795 -55
=======================================
- Hits 50735 50685 -50
+ Misses 2115 2110 -5 ☔ View full report in Codecov by Sentry. |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 28, 2025
…cebook#3436) Summary: This diff removes _gen_multiple and replaces it with calls to gen_for_multiple_with_multiple. We plan to replace gen() with gen_for_multiple_with_multiple() with the Ax1.0 release so will keep both around for now. Internal - Tldr: {F1973912988} See diff 1/n in the stack for context Reviewed By: saitcakmak Differential Revision: D67319697
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 28, 2025
…cebook#3436) Summary: This diff removes _gen_multiple and replaces it with calls to gen_for_multiple_with_multiple. We plan to replace gen() with gen_for_multiple_with_multiple() with the Ax1.0 release so will keep both around for now. Internal - Tldr: {F1973912988} See diff 1/n in the stack for context Reviewed By: saitcakmak Differential Revision: D67319697
…cebook#3436) Summary: This diff removes _gen_multiple and replaces it with calls to gen_for_multiple_with_multiple. We plan to replace gen() with gen_for_multiple_with_multiple() with the Ax1.0 release so will keep both around for now. Internal - Tldr: {F1973912988} See diff 1/n in the stack for context Reviewed By: saitcakmak Differential Revision: D67319697
lena-kashtelyan
force-pushed
the
export-D67319697
branch
from
6b66027 to
bd5d0a6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67319697 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 28, 2025
…cebook#3436) Summary: This diff removes _gen_multiple and replaces it with calls to gen_for_multiple_with_multiple. We plan to replace gen() with gen_for_multiple_with_multiple() with the Ax1.0 release so will keep both around for now. Internal - Tldr: {F1973912988} See diff 1/n in the stack for context Reviewed By: saitcakmak Differential Revision: D67319697
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Feb 28, 2025
…cebook#3436) Summary: This diff removes _gen_multiple and replaces it with calls to gen_for_multiple_with_multiple. We plan to replace gen() with gen_for_multiple_with_multiple() with the Ax1.0 release so will keep both around for now. Internal - Tldr: {F1973912988} See diff 1/n in the stack for context Reviewed By: saitcakmak Differential Revision: D67319697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff removes _gen_multiple and replaces it with calls to gen_for_multiple_with_multiple.
We plan to replace gen() with gen_for_multiple_with_multiple() with the Ax1.0 release so will keep both around for now.
Internal
Tldr:
{F1973912988}
See diff 1/n in the stack for context
Reviewed By: saitcakmak
Differential Revision: D67319697