fix: index out of bounds when blaming a file ending with a blank line #2133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2130.
It changes the following:
More details:
The highlighting procedure works on a single line. It called
str::lines
to split the code into lines. Thestr::lines
usedsplit_inclusive
internally, which omits the ending blank line (rust-lang/rust#111457). So, to overcome that, I added a blank line to the unstyled blame text.I followed the checklist:
make check
without errors