-
Notifications
You must be signed in to change notification settings - Fork 521
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
remove
use std::ascii::AsciiExt
for Rust 1.23 (#411)
In Rust 1.23, the `AsciiExt` methods are implemented directly on the concerned types, so attempting to import `AsciiExt` results in an unused import. Rust language PR: rust-lang/rust#44042 PSA: https://users.rust-lang.org/t/psa-dealing-with-warning-unused-import-std-ascii-asciiext-in-today-s-nightly/13726 This started warning as an unused import on nightly sometime between 2017-11-02 and 2017-11-09: https://travis-ci.org/exercism/rust/builds/296391447 https://travis-ci.org/exercism/rust/builds/299770403 This started warning on beta exactly when 1.23.0 became Beta (it was accepted on 1.22.0): https://travis-ci.org/exercism/rust/builds/303139434 https://travis-ci.org/exercism/rust/builds/306431846 As 1.23 is now stable and our repo disallows warnings on stable, we will need this.
- Loading branch information
1 parent
1e39915
commit 8ba3021
Showing
5 changed files
with
0 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
use std::ascii::AsciiExt; | ||
|
||
fn ascii(ch: char) -> u8 { | ||
ch as u8 | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
use std::ascii::AsciiExt; | ||
|
||
extern crate itertools; | ||
use itertools::Itertools; | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters