refactor(plugins/execute): Refactor account refunds logic

[marioevz]

🗒️ Description

Makes the following changes to help the refund logic complete in case of a failure during fixture setup:

Move Refund Logic to pre fixture

Previously the sender refund logic was placed in the base_test_parametrizer function, which is responsible for setting up the state_test, blockchain_test, etc, fixtures that are used in tests to actually generate the test.

The problem was that this fixture is not guaranteed to be the first fixture prepared during the pytest routine, so it could be that we had a fixture order preparation of:

pre -> sender -> blockchain_test

If an error occurred during the sender fixture setup, which potentially used pre fixture to fund a sender account, the refund logic would not be reached because the setup failed before reaching blockchain_test

The fix in this case is to put all the refund logic right in the pre fixture, and that way we can make sure that there is no potential fixture setup between the pre and the blockchain_test that could make the refund logic not take place.

Deprecate --sender-funding-txs-gas-price in favor of a single --default-gas-price

Use the same value as --default-gas-price instead of having two separate parameters for each use.

This is done in order to have a better estimation on replacement transactions.

Use A Replacement Transaction For Refunds

In the case of refunds, we now use a replacement transaction because it was difficult to estimate the real remaining balance of the sender account if there was a pending transaction in the mempool, so now we simply reuse the nonce to replace any transaction still present in the mempool.

Handle eth_getTransactionByHash Returning null

Handles the case where the transaction could not be found by the client and a null (None) response is returned.

🔗 Related Issues

None

✅ Checklist

• All: Set appropriate labels for the changes.
• All: Considered squashing commits to improve commit history.
• All: Added an entry to CHANGELOG.md.
• All: Considered updating the online docs in the ./docs/ directory.
• Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
• Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
• Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

[huyngopt1994]

sender_funding_transactions_gas_price I think that we should keep previous logic for supporting passing the price funding, the only change only need to pump refunding gas price from funding gas price ?

[marioevz]

Returned the parameter, but it now defaults to the same value as --default-gas-price, and we still bump the gas price for the refunds.