Skip to content

Commit

Permalink
switch to the current -std=... opts
Browse files Browse the repository at this point in the history
  • Loading branch information
@mcspr
mcspr committed Aug 17, 2020
1 parent 1a2fd27 commit 8c89d90
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/host/Makefile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,8 @@ FLAGS += -DNONOSDK221=1
FLAGS += -DF_CPU=80000000
FLAGS += $(MKFLAGS)
FLAGS += -Wimplicit-fallthrough=2 # allow "// fall through" comments to stop spurious warnings
CXXFLAGS += -std=c++11 -fno-rtti $(FLAGS) -funsigned-char
CFLAGS += -std=c99 $(FLAGS) -funsigned-char
CXXFLAGS += -std=gnu++17 -fno-rtti $(FLAGS) -funsigned-char
CFLAGS += -std=c17 $(FLAGS) -funsigned-char
LDFLAGS += -coverage $(OPTZ) -g $(M32)
VALGRINDFLAGS += --leak-check=full --track-origins=yes --error-limit=no --show-leak-kinds=all --error-exitcode=999
CXXFLAGS += -Wno-error=format-security # cores/esp8266/Print.cpp:42:24: error: format not a string literal and no format arguments [-Werror=format-security] -- (os_printf_plus(not_the_best_way))
Expand Down

1 comment on commit 8c89d90

@mcspr
Copy link
Collaborator Author

@mcspr mcspr commented on 8c89d90 Aug 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noticed in the GCC10 PR and here with cerror issue, versions matter.

Github actions don't print (or I am missing some folded log event) current env package versions, assuming that gcc --version is 7.5.0 from 18.04 aka ubuntu-latest:
/~https://github.com/actions/virtual-environments/blob/main/README.md#available-environments
/~https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu1804-README.md

Minimum for -std=c17 is 8.x.0, but my understanding is we would need to call it via gcc-{8,9}, same as g++-{7,8,9}
/~https://github.com/actions/virtual-environments/blob/main/images/linux/scripts/installers/gcc.sh

Please sign in to comment.