forked from mysticatea/eslint-plugin-node
-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(resolve): allow overriding enhanced-resolve's options #384
Merged
aladdin-add
merged 3 commits into
eslint-community:master
from
ambassify:feat/resolve-modules
Dec 10, 2024
Merged
feat(resolve): allow overriding enhanced-resolve's options #384
aladdin-add
merged 3 commits into
eslint-community:master
from
ambassify:feat/resolve-modules
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GertSallaerts
changed the title
feat(resolve): allow specifying enhanced-resolver's modules option
feat(resolve): allow specifying enhanced-resolve's modules option
Nov 14, 2024
scagood
added
enhancement
typescript
accepted
rule:update
An update to a current rule
labels
Nov 14, 2024
Thank you for you PR! I will review it first thing tomorrow morning. |
scagood
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
GertSallaerts
changed the title
feat(resolve): allow specifying enhanced-resolve's modules option
feat(resolve): allow overriding enhanced-resolve's options
Nov 15, 2024
aladdin-add
reviewed
Nov 21, 2024
aladdin-add
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to customize the config for module resolution. See: /~https://github.com/webpack/enhanced-resolve?tab=readme-ov-file#resolver-options
Old description (the PR was initially intended to only specify the
modules
option)Allows you to do things like:
src
folder as amodules
folder andrequire('models/foo');
from within yoursrc
folderBasically this: https://webpack.js.org/configuration/resolve/#resolvemodules
That second bullet point used to be possible by just setting
resolvePaths
but going from this comment on #139 that was considered an unintended side-effect or bug.